1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Improve my code quality

Discussion in 'Programming' started by zatix, Nov 26, 2010.

  1. zatix

    zatix New Member

    Joined:
    Nov 26, 2010
    Messages:
    1
    Likes Received:
    0
    Trophy Points:
    0
    Hello,

    I just took a book from the library about programming challenges, and I have decided to do some of them just for fun.

    I would be glad if you could take a look at my code and tell me some comments in order to improve my quality code.

    Thanks!

    Code:
    /*The 3n + 1 Problem
    
    PC/UVa IDs: 110101/100, Popularity: A, Success rate: low Level: 1
    
    Consider the following algorithm to generate a sequence of numbers. Start with an
    integer n. If n is even, divide by 2. If n is odd, multiply by 3 and add 1. Repeat this
    process with the new value of n, terminating when n = 1. For example, the following
    sequence of numbers will be generated for n = 22:
    
    22 11 34 17 52 26 13 40 20 10 5 16 8 4 2 1
    
    It is conjectured (but not yet proven) that this algorithm will terminate at n = 1 for
    every integer n. Still, the conjecture holds for all integers up to at least 1, 000, 000.
    For an input n, the cycle-length of n is the number of numbers generated up to and
    including the 1. In the example above, the cycle length of 22 is 16. Given any two
    numbers i and j, you are to determine the maximum cycle length over all numbers
    between i and j, including both endpoints.
    
    Input
    The input will consist of a series of pairs of integers i and j, one pair of integers per
    line. All integers will be less than 1,000,000 and greater than 0.
    
    Output
    For each pair of input integers i and j, output i, j in the same order in which they
    appeared in the input and then the maximum cycle length for integers between and
    including i and j. These three numbers should be separated by one space, with all three
    numbers on one line and with one line of output for each line of input.
    
    Sample Input Sample Output
    1 10 1 10 20
    100 200 100 200 125
    201 210 201 210 89
    900 1000 900 1000 174
    */
    #include <stdio.h>
    int main(int argc, char *argv[]) {
    	int i=atoi(argv[1]);
    	int j=atoi(argv[2]);
    	int count=0, count1=0;
    	if(i<0 || j<0 || i>1000000 || j>100000)
    		{
    		printf("All integers will be less than 1,000,000 and greater than 0");
    		return 1;
    		}
    	printf("INPUT: i=%d, j=%d\n", i, j);
    	while(i>1)
    		{
    
    		if(i%2==1)
    		{
    			i=(i*3)+1;
    		} else {
    			i=i/2;
    		}
    		count++;
    	}
    	while(j>1)
    		{
    
    		if(j%2==1)
    		{
    			j=(j*3)+1;
    		} else {
    			j=j/2;
    		}
    		count1++;
    	}
    	if(count>count1)
    		printf("\"i\" is grather, and I did %d iterations", count);
    	else
    		printf("\"j\" is grather, and I did %d iterations", count1);
    	return 0;
    	}
     

Share This Page