[redgiant]

hi ,
please refer to the code below:

//-----code follows----------------------------

#include<stdio.h>

typedef unsigned char UInt8;
typedef unsigned short UInt16;
typedef unsigned long UInt32;
typedef unsigned long long UInt64;

int main(){
   
    UInt16 lowP = 8874, lowC =61008;
    UInt16 midP = 32566, midC =32848;
    UInt8 hiP = 0, hiC =0;

   //following two lines produce wrong output, note that we dont type cast midP and midC here
    UInt64 valP = lowP + (midP << 16) + (((unsigned long long)(hiP))<<32); //line 1
    UInt64 valC = lowC + (midC << 16) + (((unsigned long long)(hiC))<<32); //line 2

    //uncommenting below two lines instead of above two lines gives right result
    
   // UInt64 valP = lowP + (((unsigned long)midP) << 16) + (((unsigned long long)(hiP))<<32);
    //UInt64 valC = lowC + (((unsigned long)midC) << 16) + (((unsigned long long)(hiC))<<32);


    UInt64 diff = valC - valP;


    printf("valP:%x\n",valP >> 32);
    printf("valC:%x\n",valC >> 32);
    
    return 0;
}


//----------------code end-----------------------------

now when I run this program I get following output:
valP:0
valC:ffffffff

However instead if I comment two lines mentioned as line1 and line2 and uncomment two lines
following in the code above, I get the following output:
valP:0
valC:0

Can somebody explain this behaviour? why this behaviour incase we dont typecast to unsigned long. This does not happen with any values but some values.

[redgiant]

just to add I am using gcc from GNU for compiling above.

[shabbir]

Welcomte to G4EF.

Use the code block for better formatting.

Thats because when you shift 16 bits for some values it becomes zero but not for all and so you get
the output unpredicted.

[redgiant]

Shifting by 16bits may give me zero but most significant 32 bits are ffffffff. In the code hiC corresponds to most significant 32 bits and value of hiC is 0. How by not typecasting midC, we are affecting most significant 32 bits?

[shabbir]

If you dont type cast it becomes long by default but with type cast it become unsigned giving it an extra bit for positive numbers. Try type casting it to long and see if the result is same.