1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Is this cose right please

Discussion in 'Assembly Language Programming (ALP) Forum' started by omaransi, Jan 5, 2007.

  1. omaransi

    omaransi New Member

    Joined:
    Dec 30, 2006
    Messages:
    5
    Likes Received:
    0
    Trophy Points:
    0
    Hi, everyone
    I have some problems with 8085 assembly in this code
    That is ,I need the user to write MOV then enters the Rs,and Rd and copies the contents of rs to rd and then display it please any one can help me
    and how I can write a line ofcode that allows the user to write e.g MOV A,B at once

    thanks

    Code:
    #include<iostream.h>
    #include<string.h>
     Void error();
    Main()
    { 
      Char opcode;
    Char rs;
    Char rd;
    Char vrs;
    Void error()
    { cout<<"Incorrect Reg.name,try again "<<endl;  }
    Xxx: cout<<"\n Enter the Opcode "<<endl;
    Gets(opcode);
    Toupper(gets(opcode));
    If(opcode!='MOV')
      {
    
     Cerr<<"\t Incorrect opcode,try again"<<endl;
    Goto xxx;
               }
    Else 	
    Error(); goto xxx;
    Gets(rs);
    Toupper(gets(rs));
    If(rs=='A'||rs=='B'||rs=='C'||rs=='D'||rs=='E'||rs=='H'||rs=='L')
     {
    Cout<<"\n Enter its value in Hexadecimal "<<endl;
    Cin>>vrs;
    Yyy :Cout<<"Enter the Destination Reg.Name "<<endl;
    Gets(rd);
    Toupper(gets(rd));
    If(rd=='A'||rd=='B'||rd=='C'||rd=='D'||rd=='E'||rd=='H'||rd=='L')
    Cout<<" "<<endl;
    
    Else
    {Error(); goto yyy; }
    
    _asm
          { 
             MVI   rd,0; Clear the det.reg.
             MVI   rs,vrs;  load the value to source reg
             Mov   rd,rs;
             MOV   ? ,[rd];   save for output later
        }  ; what I will use for ? to transfer the contents to Rd
    
    Cout<<"("<<rs<<")=" <<vrs<<endl; // show (Rs) contents
    Cout<<"("<<rd<<")="<< ?<<endl;  //show (rd) contents
    
    Return 0; }  
     
    Last edited by a moderator: Jan 6, 2007
  2. DaWei

    DaWei New Member

    Joined:
    Dec 6, 2006
    Messages:
    835
    Likes Received:
    5
    Trophy Points:
    0
    Occupation:
    Semi-retired EE
    Location:
    Texan now in Central NY
    Home Page:
    Do you want to use C or C++? I'm preparing an example, but I won't mix my code, such as you have done.

    The use of "goto", while not evil, is indicative of a poorly thought out design. The use of "gets" is an invitation to having your program entirely clobbered by the inattentive or malicious user.

    You also need to understand that case counts in C/C++. Obviously, if you've made an attempt to compile that, you have 2 tons of errors.

    Move beyond laziness. Indulge in design and thought. If you can't expend that energy, I won't expend mine for you. Learn to format your code, put it in code tags, and clean unnecessary syntax errors such as the case issue. In other words, compile it and clean up all the errors you understand. After you clean up your code, repost it. Then I can perhaps presume you're serious about getting help.
     
  3. omaransi

    omaransi New Member

    Joined:
    Dec 30, 2006
    Messages:
    5
    Likes Received:
    0
    Trophy Points:
    0
    HI,
    Ok thanks
    I am using c++ and i will try to compile it and clean up the errors and repost it


    much thanks
     
  4. DaWei

    DaWei New Member

    Joined:
    Dec 6, 2006
    Messages:
    835
    Likes Received:
    5
    Trophy Points:
    0
    Occupation:
    Semi-retired EE
    Location:
    Texan now in Central NY
    Home Page:
    Here's the deal about doing this. You want to emulate the registers in a uP. To do this, you need to tie the register identification to a variable that represents the register contents. You also need to tie an instruction mnemonic to a function that performs the instruction.

    Since register mnemonics vary from chip to chip, the best way is to define a list of register names in such a way that finding the name in the list returns an index into a set of register variables (or possibly a pointer).

    Similarly, with the opcode mnemonics. Consider a simple implementation. Operations (opcodes) may have zero, one, or two operands. Operands may be register IDs, immediate values, direct memory addresses (other variable names), or indirect memory addresses (pointers to other variable names).

    Finding a mnemonic in a list would return (or imply) information regarding the number of operands, and how to use them. One then simply calls the appropriate function, much as one would do in a calculator implementation. Determining the appropriate function could be done in a number of ways. A switch or if construct related to the index of the mnemonic could be used, or the mnemonic-search could return a function pointer.

    These operations could be performed using an array or a vector or a map. The information contained could be as simple as an index value, or as complex as a class or struct which contains all the information necessary for a particular mnemonic instruction. The class or struct could even possess information that would specify the machine code to be emitted.

    The purpose of this post is to encourage you to thoroughly think about and design your application. When that is firmly fixed, in your mind and on paper, then you can sit down and translate it into the kind of code you feel is most appropriate.
     

Share This Page